Skip to content

Adding workflow for testing custom dedicated or consumption image. #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2023
Merged

Adding workflow for testing custom dedicated or consumption image. #1186

merged 5 commits into from
Apr 19, 2023

Conversation

pdthummar
Copy link
Contributor

@pdthummar pdthummar commented Feb 24, 2023 •
edited
Loading

Description

Adding workflow for testing custom images.
Input params example:

Fixes #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Feb 24, 2023 •
edited
Loading

Codecov Report

Merging #1186 (0121b70) into dev (b923f80) will decrease coverage by 52.82%.
The diff coverage is n/a.

❗ Current head 0121b70 differs from pull request most recent head 8a8c01f. Consider uploading reports for the commit 8a8c01f to get more accurate results

@@             Coverage Diff             @@
##              dev    #1186       +/-   ##
===========================================
- Coverage   84.81%   32.00%   -52.82%     
===========================================
  Files          34       34               
  Lines        1903     1903               
  Branches      366      366               
===========================================
- Hits         1614      609     -1005     
- Misses        223     1293     +1070     
+ Partials       66        1       -65
Flag Coverage Δ
unittests 32.00% <ø> (-52.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

vrdmr
vrdmr reviewed Apr 18, 2023
View reviewed changes
@vrdmr vrdmr merged commit 35bb495 into dev Apr 19, 2023
@vrdmr vrdmr deleted the pthummar/add_custom_image_workflow branch April 19, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrdmr vrdmr vrdmr approved these changes

@gavin-aguiar gavin-aguiar Awaiting requested review from gavin-aguiar gavin-aguiar is a code owner

@YunchuWang YunchuWang Awaiting requested review from YunchuWang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdthummar @vrdmr